HCAWN / gcal-multical-event-merge

Browser extension that visually merges the same event on multiple Google Calendars into one event.
GNU General Public License v3.0
28 stars 7 forks source link

[BUG] In month view, day "pop-up" shows blank space where duplicate events have been merged #34

Open s-else44 opened 2 months ago

s-else44 commented 2 months ago

Describe the bug In month view, day "pop-up" shows blank space where duplicate events have been merged.

image

Expected behaviour Pop-up box to reduce in size, to only show scheduled events ie. no blank space where duplicates have been merged. Illustrated with red bounding box below.

image

Device

HCAWN commented 2 months ago

Hi @s-else44

I can see the issue and what item I'd have to change though not sure how easy it would be. As I'm sure you know, the popup is rendered that size as that's the size it would need to be the render the events before the extension compressed them ontop of each other.

So I can ascertain the importance of this body of work. What are your reasons for wanting the popup to be shortened? Purely aesthetic or functional in some way?

H

s-else44 commented 2 months ago

Hi Henry,

Thanks for your reply.

For me, it's purely aesthetics I suppose - a suggestion for improvement if you are undertaking any major upgrades at any point. Otherwise, I really love the extension.

Many thanks - Steph


From: Henry Neilson @.> Sent: 12 September 2024 09:48 To: HCAWN/gcal-multical-event-merge @.> Cc: s-else44 @.>; Mention @.> Subject: Re: [HCAWN/gcal-multical-event-merge] [BUG] In month view, day "pop-up" shows blank space where duplicate events have been merged (Issue #34)

Hi @s-else44https://github.com/s-else44

I can see the issue and what item I'd have to change though not sure how easy it would be. As I'm sure you know, the popup is rendered that size as that's the size it would need to be the render the events before the extension compressed them ontop of each other.

So I can ascertain the importance of this body of work. What are your reasons for wanting the popup to be shortened? Purely aesthetic or functional in some way?

H

— Reply to this email directly, view it on GitHubhttps://github.com/HCAWN/gcal-multical-event-merge/issues/34#issuecomment-2345658074, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BLHOWSP5FQRH6ZN3YLNX6B3ZWFINZAVCNFSM6AAAAABOCVDAGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBVGY2TQMBXGQ. You are receiving this because you were mentioned.Message ID: @.***>