HCAWN / gcal-multical-event-merge

Browser extension that visually merges the same event on multiple Google Calendars into one event.
GNU General Public License v3.0
28 stars 7 forks source link

[BUG] Blank lines between merged events #38

Closed celiasmith closed 3 weeks ago

celiasmith commented 2 months ago

Describe the bug Display of merged events has blank lines between them, both in month view and month popup

To Reproduce

  1. Happens with all merged events image image

Expected behaviour

  1. No blank lines between events. This is a functional issue in the month view, as only a few events are shown on days that have many until you click the '5 more' at the bottom.

Device

HCAWN commented 2 months ago

Hi @celiasmith I will have a look tomorrow but strongly suspect this is caused by the same thing that partially broke the extension last week: https://github.com/HCAWN/gcal-multical-event-merge/issues/36 Google changed some of the code in the calendar app for the first time in years and years. I'll make the fix tomorrow and tag you/this thread as it progresses to being live.

H

celiasmith commented 1 month ago

Not sure on etiquette for inquiring about a possible fix, but I was wondering if you had a chance to look at this one @HCAWN ?

Gubbahubba commented 4 weeks ago

Same here. Looking very much forward to your fix, this would honestly be a gamechanger for me @HCAWN Keep up the good work.

HCAWN commented 3 weeks ago

@Gubbahubba & @celiasmith

https://github.com/HCAWN/gcal-multical-event-merge/pull/40

Have made this ^ fix, it's a very small change to dail with the ongoing changes Google made to their code last month. Will post here when the extension is live and requires a refresh, please let me know if that fixes the issue for you and then I'll close this issue>

H

HCAWN commented 3 weeks ago

2.3.11 live now

Gubbahubba commented 3 weeks ago

Fantastic, it works! Thank you!

celiasmith commented 3 weeks ago

Yup, much better for me too! Thanks. (I do still get 'empty' space in the main calendar view, but this was the case before as well
image )

HCAWN commented 3 weeks ago

Resolved, still https://github.com/HCAWN/gcal-multical-event-merge/issues/34