Out of office should use "past event" style text

HCAWN / gcal-multical-event-merge

Browser extension that visually merges the same event on multiple Google Calendars into one event.

GNU General Public License v3.0

28 stars 7 forks source link

Out of office should use "past event" style text #5

Closed michaelblyons closed 2 years ago

michaelblyons commented 2 years ago

Since OOO events are dimmed, they always use the grey text instead of white-with-shadow.

HCAWN commented 2 years ago

@michaelblyons please share a screenshot of this as I'm not sure if https://github.com/HCAWN/gcal-multical-event-merge/pull/9 address this issue or not.

michaelblyons commented 2 years ago

Screen Shot 2022-08-22 at 9 49 26 AM

Merging events makes them extremely hard to read. I think my initial bug report was unclear about which style was better.

HCAWN commented 2 years ago

This is how it looks on the new PR. I'm unsure if the white font is because your OOO event is appearing differently to how I see it. is that on Weekly view calendar?

michaelblyons commented 2 years ago

It is indeed on the Weekly view calendar, but those ones were not all-day events.

Screenshot above looks great for #6.

HCAWN commented 2 years ago

fixed now

HCAWN commented 2 years ago

https://github.com/HCAWN/gcal-multical-event-merge/commit/8b9cdbcc10e8ada88d5f7b1fe0a36303df3419b6