HCL-TECH-SOFTWARE / hclds-keycloak

The HCL Digital Solutions (DS) Keycloak service is based on Keycloak and adds configuration, an HCL branded login UI and more. It serves as a reference for OIDC based authentication across DS products.
Apache License 2.0
1 stars 3 forks source link

provider identifier should be equal #2

Closed marde16 closed 7 months ago

marde16 commented 11 months ago

In Configure Keycloak as an OIDC IdP for HCL Connections keycloak is used as provider.identifier while hcl is used in Configuring the OIDC RP TAI against your IdP

Redirect URI definition in Configure Keycloak as an OIDC IdP for HCL Connections https://github.com/HCL-TECH-SOFTWARE/hclds-keycloak/blob/b6ef56962ab2bfddef405ec0f3faeced28815e06/docs/integration/ds-integration/cnx-keycloak-configuration.md?plain=1#L33

provider.identifier definition in Configuring the OIDC RP TAI against your IdP https://github.com/HCL-TECH-SOFTWARE/hclds-keycloak/blob/b6ef56962ab2bfddef405ec0f3faeced28815e06/docs/integration/ds-integration/cnx-integration.md?plain=1#L74

Both names for the provider identifier have to be equal.

caiaga commented 11 months ago

@marde16 Thank you for bringing this up and the raised PR as well. You are right and we will look into adjusting this mismatch. We have some more points raised on the Connections OIDC documentation piece, which we currently review and plan to work back into it.

VinayakPatilHcl commented 7 months ago

Corrected provider identifier values as part of https://github.com/HCL-TECH-SOFTWARE/hclds-keycloak/pull/8