search

HCLarsen / devise-uncommon_password

Devise extension to prevent users from using a common password.
MIT License
28 stars 20 forks source link

updates for rails 7.2 #61

Closed MichaelWhi closed 1 month ago

MichaelWhi commented 2 months ago

updates some files for rails 7.2

tests did not work as expected, can you please review?

thanks for the gem!

HCLarsen commented 2 months ago

I'm going to resolve the issues with the tests before merging.

HCLarsen commented 2 months ago

I've updated the main branch. If you update this branch with those changes, and address the conflict in Gemfile.lock, your tests should run properly.

MichaelWhi commented 1 month ago

Thanks! Now tests run with Rails 7.2:

...
Using rails 7.2.1 (was 7.1.4)
Using devise-uncommon_password 0.4.5 from source at `.`
Bundle updated!

@MichaelWhi ➜ /workspaces/devise-uncommon_password (feature/rails-7-2) $ bin/test
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
Run options: --seed 15064

# Running:

.......

Finished in 1.525939s, 4.5873 runs/s, 134.9988 assertions/s.
7 runs, 206 assertions, 0 failures, 0 errors, 0 skips