search

HDF-NI / hdf5.node

A node module for reading/writing the HDF5 file format.
MIT License
123 stars 40 forks source link

Latest Node API + various cleanup #38

Closed Y-- closed 7 years ago

Y-- commented 7 years ago

Thanks a lot for the merge @rimmartin !

rimmartin commented 7 years ago

Thanks for the yeomen work:-)

I'll look thru and update the documentation

rimmartin commented 7 years ago

And test my stuff and then publish to npm

Y-- commented 7 years ago

Awesome, thanks a lot!

Would you be interested in a PR that would normalize the code and remove the commented out pieces? We would use clang-format for that : https://clang.llvm.org/docs/ClangFormat.html

rimmartin commented 7 years ago

absolutely! Now would be a great time.

So that I stay compatible what clang formatter do you use? I've used netbeans in the past for formatting but I don't recall a clang format choice there

Y-- commented 7 years ago

Excellent, I've submitted this PR https://github.com/HDF-NI/hdf5.node/pull/39 The .clang-format configuration file is also included in the source file. Of course this is just a suggestion, we can definitely adjust it and I will update the PR.

Thanks a lot!