HDFGroup / HDF.PInvoke

Raw HDF5 Power for .NET
http://www.hdfgroup.org/HDF5
Other
81 stars 29 forks source link

.targets file name must match NuGet package id #142

Closed dynamatt closed 6 years ago

dynamatt commented 6 years ago

According to https://blog.nuget.org/20141023/package-manifests.html:

NuGet looks in the \build folder for props and targets files where the filename matches the package id.

This means that the targets will not be properly loaded unless the .targets file has the same name as the package ID. I believe this may fix issues #129 and #130.

Hence the "hdf5.targets" file should be renamed to "HDF.PInvoke.targets.

dynamatt commented 6 years ago

Yes, I think so, but I’m not really an expert on how things used to be done - I just found this document. It’s also related to the new format of importing into .csproj files. When you use this format the packages are cached into your %userprofile%/.nuget/packages folder rather than a packages folder in the solution directory. I think this is why we need to use .targets instead of a post-build action.