search

HDFGroup / HDF.PInvoke

Raw HDF5 Power for .NET
http://www.hdfgroup.org/HDF5
Other
81 stars 29 forks source link

Dependency on vcruntime140.dll #183

Closed PhilPJL closed 2 years ago

PhilPJL commented 2 years ago

After installing our application on a fresh install of Windows 10 it appears there's a dependency on vcruntime140.dll when using HDF.PInvoke.1.10 (1.10.612). This can be verified by using a dependency checker such as this https://github.com/lucasg/Dependencies. image This is showing the dll installed in system32 on my dev box. The dll isn't there by default.

This is easily remedied but maybe vcruntime140.dll should be included in the package?

Apollo3zehn commented 2 years ago

Hi @PhilPJL,

I know this is a bit annoying but I find it cleaner to require the user to install the required C runtime as described here (https://github.com/HDFGroup/HDF.PInvoke.1.10#prerequisites) since this is official way to get that .dll.

Additionally, I do not know how VCRUNTIME140.dll is licensed and if we would be allowed to provide a copy of it.

Apollo3zehn commented 2 years ago

https://docs.microsoft.com/en-us/cpp/windows/redistributing-visual-cpp-files?view=msvc-170#install-the-redistributable-packages also mentions the advantage of installing the redistributable package:

The Visual C++ Redistributable Packages install and register all Visual C++ libraries. If you use one, run it as a prerequisite on the target system before you install your application. We recommend that you use these packages for your deployments because they enable automatic updating of the Visual C++ libraries.

PhilPJL commented 2 years ago

ok thanks for the info.