HDFGroup / datacontainer

Data Container Study
Other
8 stars 1 forks source link

Modification to S3Download() and more... #18

Closed ghost closed 8 years ago

ghost commented 8 years ago

This branch started as my modifications to the S3Download() class but now holds more than just that. As for the S3Download() mods:

Other notable changes so far:

jreadey commented 8 years ago

Nice updates!

Hardcoding to /mnt seems a little dangerous (esp. as we have a function to rm -rf all files in this directory).

How about reverting to the env variable and I'll update the engine snapshot to create /mnt/s3 on startup if it is not present?

BTW - I was planning to update summary.py to use s3download today.

ghost commented 8 years ago

Hardcoding to /mnt seems a little dangerous (esp. as we have a function to rm -rf all files in this directory).

/mnt is meant to be place for ephemeral data.

How about reverting to the env variable and I'll update the engine snapshot to create /mnt/s3 on startup if it is not present?

I wanted to avoid having to build a new snapshot each time this location changes but am not religious about it. Change if you want.

BTW - I was planning to update summary.py to use s3download today.

Great! Go for it.