Closed jonrkarr closed 1 year ago
Could be linked to https://github.com/HDFGroup/h5pyd/pull/114
Yes, #114 sounds very similar.
This should be fixed in this commit: https://github.com/HDFGroup/h5pyd/commit/5a9193af6ae99a204a7d277d9983431e712f7417.
I'll update the issue when this gets merged with master.
Fix is in master now.
Closing - fix is in the 0.12.0 release on PyPI.
Sorry, I was a bit late to check.
I still get an error when running hsload --link
on a file containing an empty dataset (h5py.Empty
):
File ".../h5pyd/_apps/utillib.py", line 737, in create_dataset
tgt_shape.extend(dobj.shape)
TypeError: 'NoneType' object is not iterable
Ah, I see - reopening.
This should fix it: https://github.com/HDFGroup/h5pyd/commit/866c0be4063a1d744df596a8296b95a2b505ee15.
Nope, still the same error.
Anyway, this is no big deal: hsload
now works for scalar datasets and I think h5py.Empty
is really uncommon.
@loichuder - where you testing from master? The commit above was in the aggregate branch. Anyway, I've merged the changes into master and pushed out a new release as 0.12.1.
Yes tried with the aggregate
branch at the time and now with master
, still the same issue of https://github.com/HDFGroup/h5pyd/issues/116#issuecomment-1336931275 since dobj.shape
is None
for h5py.Empty
.
No big deal as I said but for the sake of it, here is what I have done to encounter the issue:
import h5py
with h5py.File('empty.h5', "w") as h5file: h5file.create_dataset("empty", data=h5py.Empty)
- Loading with `hsload --link`:
hsload --link [...] files/empty.h5 [...]
@loichuder - ok I see. This latest checkin should really fix it now! It's on master and in PyPI as version 0.12.2.
Closing this issue as it should be fixed in 0.12.2 and later.
Below is an error we encountered. The error is that hsload fails on data sets that have a dimension of length 0.
(While I'd expect HSDS to be able to handle this, incidentally this error was actually helpful to us! This alerted us to a case where simulation data unexpectedly wasn't produced due to an error in our code.)