HDFGroup / h5pyd

h5py distributed - Python client library for HDF Rest API
Other
110 stars 39 forks source link

Support complex numbers #61

Closed ghost closed 5 years ago

ghost commented 5 years ago

Was not able to run entire h5pyd test suite but I did test dataset read/write of complex numbers. Not tried complex numbers in attributes.

jreadey commented 5 years ago

This looks nice.

What's going on with the Travis build? Do all the tests pass on your desktop?

ghost commented 5 years ago

I could not get tests to run on my computer so am going to rely on (abuse) Travis a bit. 😞

ghost commented 5 years ago

The tests pass for HSDS but fail for h5serv. The tracebacks indicate that h5json needs to be upgraded to handle NumPy's complex datatype.

jreadey commented 5 years ago

I've been pretty liberal with skipping the test when the server is h5serv if the feature is supported on HSDS but not h5serv. See for example, line 34 here: https://github.com/HDFGroup/h5pyd/blob/master/test/test_table.py.