search

HDFGroup / hdf-compass

Python-based viewer for HDF5 on other file formats
Other
131 stars 26 forks source link

The app hangs when using X frame button to close it. #135

Closed giumas closed 9 years ago

giumas commented 9 years ago

On Windows, after a call to matplotlib, when the [X] frame button is clicked to close the last frame, the app hangs.

The issue is related to a misinterpretation of wx.ID_CLOSE that is only for button. The function on_window_close is actually never been called (https://github.com/HDFGroup/hdf-compass/blob/develop/hdf_compass/compass_viewer/frame.py)

giumas commented 9 years ago

The PR https://github.com/HDFGroup/hdf-compass/pull/137 solve the issue by counting the open frames (and calling wx.GetApp().Exit() for the last one).