search

HDFGroup / hdf-rest-api

12 stars 5 forks source link

`query_domain` is not required #11

Open Apollo3zehn opened 1 year ago

Apollo3zehn commented 1 year ago

The query_domain parameter is not marked as required:

grafik

So I should be allowed to ignore that parameter, but when I do this, the response is 404:

grafik

Is this the intended behavior?

Apollo3zehn commented 1 year ago

@gheber I am working on auto-generated C# and Python clients for the HSDS REST API based on the openapi.yml file in this repo. (Here are the nearly finished client implementations). The only thing I am wondering about is if the domain parameter is really optional. It would be great if you could clarify this. Thanks!

Apollo3zehn commented 1 year ago

I found this code: https://github.com/HDFGroup/hsds/blob/40671b845445d215911d47ef3c6c5b9f61f8640c/hsds/domain_dn.py#L34-L43

It seems there is a fallback option to provide the domain in the body but I cannot find the corresponding body description in the openapi.yml :-(