search

HDFGroup / hdf4

Official HDF4 Library Repository
Other
12 stars 24 forks source link

Improve mfhdf tests #614

Closed bmribler closed 4 months ago

bmribler commented 5 months ago

Moved long/cluttered test functions out of the main test file hdftest.c.

derobins commented 4 months ago

@byrnHDF - Why is this failing? I don't see anything that @bmribler changed that would cause CMake to fail and it passes CTest on my Linux machine.

bmribler commented 4 months ago

It was the failure like this one, which I've seen it last year and I asked @byrnHDF about it, but we couldn't figure out what it was:

Test # 66: MFHDF_TEST-hdftest ...........................***Failed Required regular expression not found. Regex=[HDF-SD test passes ]

I googled, some people said something about the CMake version. They reinstalled CMake and the problem was gone. Have you heard anything about that? But all the other tests passed!

(that was what I asked last year)

derobins commented 4 months ago

It's weird because it passes everywhere else, the line set (passRegex "HDF-SD test passes") is clearly set in CMakeTests.cmake, and you didn't change anything regarding CMake.

derobins commented 4 months ago

The problem was a missing return statement on a function that returned an int, so apparently on MacOS it returned non-zero trash, which was interpreted as errors.

bmribler commented 4 months ago

Thank you!