search

HDFGroup / hdf5-iotest

HDF5 Performance Analysis Checklist
Other
12 stars 9 forks source link

HDF5 version requirement #22

Closed wkliao closed 1 year ago

wkliao commented 1 year ago

https://github.com/HDFGroup/hdf5-iotest/blob/462837bedb126210b5ac3b8e8f3ac2e4b0eef5b4/src/utils.c#L214

As HDF5 has released 1.14.0, this line of version number check raises an assertion.

hdf5_iotest: src/utils.c:214: set_libver_bounds:
Assertion `majnum == 1 && minnum >= 8 && minnum <= 13' failed.

Maybe the last condition "&& minnum <= 13" can be removed?

wkliao commented 1 year ago

Just to point out that the HDF5 develop branch has set the version to 1.15.0. https://github.com/HDFGroup/hdf5/blob/509fe962d42b3f02d356d2668b04712df06daf7f/configure.ac#L25

So this line of github actions file main.yml which clones the branch develop may fail. https://github.com/HDFGroup/hdf5-iotest/blob/462837bedb126210b5ac3b8e8f3ac2e4b0eef5b4/.github/workflows/main.yml#L58 Is there a reason to set an upper bound for minnum ?

brtnfld commented 1 year ago

It is a reminder that the library bounds need to be updated when a new 1.x release is made. It should (does) work with 1.15 (develop).

wkliao commented 1 year ago

Hi, @brtnfld Could you please merge #23 to the master branch, so I can use it in the Log VOL tests?

brtnfld commented 1 year ago

Sorry about that. Done.

wkliao commented 1 year ago

Thanks, Scot !