search

HDFGroup / hdf5-iotest

HDF5 Performance Analysis Checklist
Other
12 stars 9 forks source link

Update main.yml #26

Closed Noerr closed 1 year ago

Noerr commented 1 year ago

Attempting perhaps hacky fix to missing sudo apt-get update command. Submitting pull request now, because I'm thinking this will trigger the CI action and thus test my idea.

Noerr commented 1 year ago

Ok, so the guess at a fix here isn't perfect, but it is effective as-is. I observed that the number of steps is different when I changed this main.yml file than when I changed just the README file previously. In the later, the stage "Update repository code" is not executed and thus sudo apt-get update was not run. The CI fails. Here, in the CI checks for this pull request sudo apt-get update is run twice! I don't understand this stuff enough to remove the redundancy.

brtnfld commented 1 year ago

I pushed a fix, it should be fixed now.

Noerr commented 1 year ago

Ah, I see. the main.yaml and the CI was changing at the same time I was trying to understand it.