Report fill value only if deliberately set

HDFGroup / hdf5-json

Specification and tools for representing HDF5 in JSON

https://hdf5-json.readthedocs.io

Other

72 stars 25 forks source link

Report fill value only if deliberately set #38

Closed ghost closed 8 years ago

ghost commented 8 years ago

jsontoh5 currently reports fill value every time regardless if it is set or default. I suggest utilizing h5py.h5p.PropDCID.fill_value_defined() and only reporting fill value in output JSON if the method reports the value h5d.FILL_VALUE_USER_DEFINED.

jreadey commented 8 years ago

This got fixed in this commit: https://github.com/HDFGroup/hdf5-json/commit/b4e0dea4f88c6535bbe50e0b3a6ed3b9ea6526bf.