HDFGroup / hdf5-json

Specification and tools for representing HDF5 in JSON
https://hdf5-json.readthedocs.io
Other
72 stars 25 forks source link

Report fill value only if set by application #41

Closed ghost closed 8 years ago

ghost commented 8 years ago

This PR addresses the issue #38. Dataset's fill value now appears in HDF5/JSON only if different than the default. The important code change is here.

Including only non-default fill values may also help avoid h5py's segmentation faults when dealing with string datasets. It should now crash only when string datasets do indeed have a set fill value. :-)

Also, I did a fair bit of code clean-up of hdf5db.py to improve its PEP-8 compliance.

jreadey commented 8 years ago

Nice!