Closed jreadey closed 9 years ago
@ajelenak-thg - take a look at this. There are a couple of cases (e.g. compound.json) where PR #41 seems to have incorrectly removed that fill values.
@jreadey Was compound.json generated from compound.h5? In compound.json, the /dset's fill value is:
"fillValue": [
999,
"99:90",
999,
999.0,
"N"
]
but h5dump -p -A ../data/hdf5/compound.h5
reports a different fill value:
FILLVALUE {
VALUE {
0,
"\000\000\000\000\000\000",
0,
0,
"\000\000\000\000\000\000"
}
}
I'm not sure. But if I convert the old json (with fill values) to hdf5 and the hdf5 back to json it retains the fill value. I'll revert the json/compound.json and update the hdf5/compound.h5 files.
PR is updated.
@jreadey Are there any other issues? Is this PR ready for merging?
Yes, I've merged.
JSON data file updates