search

HDFGroup / hdf5-json

Specification and tools for representing HDF5 in JSON
https://hdf5-json.readthedocs.io
Other
73 stars 25 forks source link

Support Python 3 (work in progress) #45

Closed mivade closed 8 years ago

mivade commented 8 years ago

This is a work in progress. Several tests fail at present, mostly related to confusion between str and bytes. I will go through test failures and fix the obvious problems and mark the less obvious problems.

jreadey commented 8 years ago

Nice code cleanup! I made one comment in the file change listing - can you look at it?

The failures all seem related to attributes. Are there any other types?

mivade commented 8 years ago

The line change is fixed. It was related to accidentally deleting a ret = ... statement for which ret was not actually used. This then made the linter complain about assigning aid but never using it (which of course I don't use it if I delete that line!). I have added the assignment of aid back but removed assigning ret (still doing the aid.write call, however).

In this second take, I haven't seen any other errors yet. What I noticed on the first try was that getting some of these tests to pass resulted in further errors down the line. It would be nice to streamline the testing a bit, but I think that should wait until the remaining issues here can be resolved.

jreadey commented 8 years ago

Merging since everything checks out with py27.