HDFGroup / hdfview

Other
65 stars 15 forks source link

HDFView 3.3.0 shows incorrect references in compound types in datasets #147

Closed rly closed 1 year ago

rly commented 1 year ago

I have an HDF5 file with a dataset with a compound dtype consisting of (int, int, object reference to a group). Displaying this data in HDFView is incorrect. All the object references are to the same first group.

Here is a zip file with an example single 182 KB .h5 file test_tsref.h5.zip (GitHub does not allow uploading files with h5 extensions, so I zipped it. Happy to share it elsewhere if that is preferred)

The dataset is at /acquisition/test_dynamic_table/test_timeseries_reference_vector_data

image

The two rows should have different object references: /acquisition/test_timeseries1 and /acquisition/test_timeseries2.

byrnHDF commented 1 year ago

references in compound container types has had many issues, this looks like it may be another. I will debug and locate the problem to see if there it is an issue in the object library or in the JNI interface of hdf5.

byrnHDF commented 1 year ago

This turned out to be real simple, just needed to use the supplied index in the arraycopy for object refs.

byrnHDF commented 1 year ago

Fixed in 3.3.1 release

rly commented 1 year ago

Thanks!