Closed bilalshaikh42 closed 2 years ago
I think that would be ok - I don't see any code where there's a catch for KeyError with the handler doing something other than setting the value to be None.
But is the yaml clutter a big concern? Having all the keys defined in config.yml is documentation (of a sort) of the available config options. Specific deployments can use override.yml for those keys that need to be changed.
The majority of keys in the conifg.yaml are not relevant for every installation. However, they must still be specified in the yaml leading to clutter.
For example, I ran into the following error since I forgot to specify the
aws_dynamodb_gateway
even though it is not used.This can be fixed by changing the following line to remove the check for default being null. @jreadey would returning None if the default is None cause any issues?
https://github.com/HDFGroup/hsds/blob/546de9de21943f73df191a876f59cc89cf53b197/hsds/config.py#L173-L184