Allow use of unsigned requests to S3

HDFGroup / hsds

Cloud-native, service based access to HDF data

https://www.hdfgroup.org/solutions/hdf-kita/

Apache License 2.0

128 stars 53 forks source link

Allow use of unsigned requests to S3 #157

Closed mbruggs closed 2 years ago

mbruggs commented 2 years ago

I'm working on a project in which the S3 buckets are public and therefore don't require any AWS credentials. The commit adds a new config option to achieve the same behaviour that AWS CLI gives with --no-sign-request.

Please let me know if there is anything that you think could be done better.

Thanks again for the work on HSDS.

jreadey commented 2 years ago

Nice! One suggestion: can you update to use the "default" option in config.get()? This will avoid problems if anyone is running with an older version of the config.yml.

mbruggs commented 2 years ago

Good catch, thanks. Updated with False as the second argument.

jreadey commented 2 years ago

Merged! Thanks for the contribution.