search

HDFGroup / hsds

Cloud-native, service based access to HDF data
https://www.hdfgroup.org/solutions/hdf-kita/
Apache License 2.0
126 stars 52 forks source link

Groupcreateprop #220

Closed jreadey closed 1 year ago

jreadey commented 1 year ago

Add support for datasets created with compact and contiguous layouts.

mattjala commented 1 year ago

The changes with H5D_CONTIGUOUS and H5D_COMPACT work fine.

The creationProperties field also works, except in the case of the root group. Because the root group of a domain is created when the domain is created, the body of the request has to be checked for creationProperties at domain creation time. So as written, there's no way to set the creation properties for the root group.

I was able to have the root group inherit a creation property list sent at file creation by adding this after line 1121 in domain_sn.py

if body and "group" in body and "creationProperties" in body["group"]:
    group_json["creationProperties"] = (body["group"])["creationProperties"]
jreadey commented 1 year ago

Good catch about the root group property list. I've checked in your suggested change.