search

HDFGroup / hsds

Cloud-native, service based access to HDF data
https://www.hdfgroup.org/solutions/hdf-kita/
Apache License 2.0
129 stars 53 forks source link

Remove passwords from build image #45

Closed jreadey closed 4 years ago

jreadey commented 4 years ago

Including usernames and passwords as part of the Docker image is problematic - for one it makes it impossible to distribute images via Docker hub or other public repo.

Rather than building in the password file, either mount the file (for Docker deployments) or create a secret (for Kubernetes).

jreadey commented 4 years ago

Docker compose files have been updated to mount password file. E.g: https://github.com/HDFGroup/hsds/blob/master/docker-compose.yml. And Kubernetes_deployment scripts use password secret.