search

HDFGroup / hsds

Cloud-native, service based access to HDF data
https://www.hdfgroup.org/solutions/hdf-kita/
Apache License 2.0
129 stars 53 forks source link

Use sdist and install from tarball in docker #61

Closed t20100 closed 2 years ago

t20100 commented 4 years ago

Following https://github.com/HDFGroup/hsds/pull/35#issuecomment-632186279, this PR proposes to build the source tarball and use it instead of the source directory to build the docker image so as to avoid copying the whole source directory.

--no-binary hsds is there to avoid building (and thus storing) the corresponding wheel in the docker image.

This is probably a bit cleaner but I think it has little advantage over the current way: it makes sure only relevant files are used to install hsds but at the expense of an extra python setup.py build step...

t20100 commented 4 years ago

Typo fixed, using sdist rather that build

jreadey commented 2 years ago

@t20100 - I think setup.py has evolved so this PR doesn't work as is. I've made some equivalent changes here: https://github.com/HDFGroup/hsds/commit/0b71becec8a6d6fd1de589ab3601199fc1fbb2c1. I think this resolves the issue of image size blowing just because I left a 1gb size file in my source tree!