Database() initialization should treat DB path differently

HDI-Project / ATM

Auto Tune Models - A multi-tenant, multi-data system for automated machine learning (model selection and tuning).

https://hdi-project.github.io/ATM/

MIT License

525 stars 141 forks source link

Database() initialization should treat DB path differently #115

Closed RogerTangos closed 5 years ago

RogerTangos commented 5 years ago

Currently, db path is relative to the Database() caller. It should either be relative, or relative to the Database.__class__.__file__ (not sure about my syntax there)

This confused me when I instantiated a database using the sql.yaml file, and the db instance kept creating and referencing an empty database. I didn't understand why it was empty and spent way too much time debugging a working session.

micahjsmith commented 5 years ago

Thanks for reporting. Where in the code are you finding this to occur?

RogerTangos commented 5 years ago

I'd actually totally forgotten about this until just now. I encountered this when working on the (unfinished) api, and since worked around it. I'm closing the ticket unless it comes up again (at which point, I'll just fix and submit a PR)