search

HDIAndrew / EFS

12 stars 0 forks source link

Replacing money offer with different clause doesn't give money back #130

Closed cranky-corvid closed 1 year ago

cranky-corvid commented 1 year ago

Description:

Expected behavior: When modifying a diplomatic offer, if I replace a "Give you money" clause with a different clause, the money tied up in the diplomatic offer should be added back to my treasury.

Actual behavior: While cancelling a "Give you money" clause gives the money back, replacing it with a different clause without cancelling first does not.

Game version:

1.5 Vanilla

Steps to reproduce:

  1. Start a game on the default settings
  2. Go to Diplomacy
  3. Select the Church
  4. Add a 'Give you money' clause including all your money
  5. Click on the 'Give you money' clause, click on 'Appreciate it'
  6. Check whether you have any money anymore

Additional information:

Matt-Caspermeyer commented 1 year ago

I have an update on this issue.

This issue has been fixed and is currently undergoing our testing, review, approval, and merging process. We hope to have this process completed soon and to provide this fix in a future V1.51 update.