1.5.1c - opening video defaults to OFF

floralpond commented 1 year ago

Description:

Opening videos do not play by default in 1.5.1c.

Expected behavior: When a player hasn't modified any files, they should see the opening videos when starting the game.

Actual behavior: The opening videos do not play by default. If changing efs.ini to videos=1, then they do play.

Game version:

1.5.1c

Steps to reproduce:

Run the game
see no video

Additional information:

HDIAndrew commented 1 year ago

Thanks Jonathan. We need a check list of these before 1.51 goes gold:

Ensure video is on
Ensure music is on
Ensure sound effects are on
Ensure there are no extra .sav files in the SAV directory
Ensure saved galaxies are final versions
Ensure credits are correct
Ensure DAT files are the Core ones

Anything else?

floralpond commented 1 year ago

Yep good thinking.

I'd probably add

Ensure no mods are accidentally added (or rather, unintended mods, if we are including a mod in the package)
Ensure dxcfg.ini has correct default settings
Ensure mod.ini has correct default settings (default to off)

Anything in EFS.ini, the mods folder, save files, auto galaxies, those are all things that are pretty usual to be changed/added during normal playthrough (so like for example when I'm testing from visual studio, I'm going to change to windowed mode in dxcfg.ini, and likely make changes to EFS.ini or enable a mod and change efs.ini through there, and so it's not weird to me for these sorts of things to be tailored during the PR testing process).

HDIAndrew / EFS