HDIAndrew / EFS

12 stars 0 forks source link

1.5.1c - Eye of the Prophet relic doesn't boost accuracy #142

Closed floralpond closed 1 year ago

floralpond commented 1 year ago

Description:

Eye of the prophet description says "Stack accuracy bonus". However, it does not seem to actually provide any accuracy bonus. I'm not sure if other relics have the same issue, I can test them.

Expected behavior: When Theurgy is researched, Eye of the Prophet should give a bonus of 8 accuracy for the stack.

Actual behavior: When Theurgy is researched, Eye of the Prophet does not appear to give any bonus for the stack. But the green message is still displayed on the combat screen, making you think it's active even though the bonus doesn't work.

Game version:

1.5.1c, using some modded unit.dat files to provide controlled test scenario (included in zip file)

Steps to reproduce:

accuracy_relic_test.zip

  1. Open the zip file which has the modded files and activate the mod in mod.ini.
  2. load the save file
  3. In the church on Kish, there should be a stack of artillery that are modded to have an accuracy of 1 for indirect, and no close attack.
  4. Note that the church also has an Eye of the Prophet relic, and Theurgy is already researched in this save file.
  5. Next to the church on Kish, there is a stack of rebel spies (1 camo and 10 agility), assassins (1 camo and 11 agility), and doplegangers (1 camo and 12 agility).
  6. If you use an artillery to attack the spies, the artillery will kill them all
  7. If you use an artillery to attack the assassins, the artillery will kill them all
  8. If you use an artillery to attack the dopplegangers, there will be an infinite loop message, and dopplegangers won't take any damage
  9. If you use an artillery + the Relic in the church to attack the dopplegangers, you still get the infinite loop message and dopplegangers won't take any damage, but in the combat screen you see the green text saying the relic is activated.

Therefore, the conclusion is that we know the 1 accuracy artillery can hit 10 agility, and 11 agility, but not 12 agility. So any bonus at all should allow them to hit the 12 agility, but it's not.

Additional information:

  1. I also tried boosting the bonus to 200 to see if maybe it was a multiplier instead of an addition, but that didn't seem to do anything.
  2. At Jakalor's suggestion, I also tested using an artillery with an officer or noble to attack the dopplegangers to see if the accuracy bonus from them worked, and found that it works as expected. The artillery with an officer or noble can hit the dopplegangers, but can't with the Eye of the Prophet relic.
  3. I'm not sure if there is also an issue with the other relic bonuses, like defense and strength. If I find other issues with relics like this , I'll expand the bug report to include them, but thought I'd throw this out there for faster visibility.
    • EDIT: I've confirmed in controlled testing that the following relics work as expected:
    • productivity bonus
    • stack strength bonus
    • Stack Research bonus
    • Stack Defense bonus
Xenotrenium commented 1 year ago

How did you ascertain the relic in the save? Did it pass hands and\or did you get it from ruins directly?

floralpond commented 1 year ago

I used the map editor to give myself the relics. Note that other relics obtained this way seem to work fine (such as productivity, strength, defense, and research). To your point, I was able to reproduce the "relics stop working when captured" issue and wrote up a separate issue for that, since I don't see one written up yet.

Matt-Caspermeyer commented 1 year ago

I have an update on this issue.

I have created a fix and it is currently undergoing our testing, review, approval, and merging process.

We hope to have the update provided in the V1.51 patch in the near future...