HDIAndrew / EFS

12 stars 0 forks source link

1.5.1c - St. Almathea's Lancet relic doesn't prevent plague in stack #143

Closed floralpond closed 1 year ago

floralpond commented 1 year ago

Description:

With Theurgy researched, St. Almathea's Lancet relic doesn't prevent plague in stack.

Expected behavior: With Theurgy researched, St. Almathea's Lancet relic should prevent plague in stack. Note: this relic is set to 100 in relics.dat by default. I assume this means 100% protection from plague in stack, but I'm not sure. It'd be nice to have more details in the relic.dat file.

Actual behavior: With Theurgy researched, St. Almathea's Lancet relic doesn't prevent plague in stack.

Game version:

1.5.1c, with some modification controlled testing (such as rebel player skip turn, and making Theurgy easier to research, adding a rebel plague bomb nearby relics on home planet)

Steps to reproduce:

plague_test.zip

  1. Open plague_test.zip file into mods folder and enable the mod
  2. Load the save file
  3. Check that theurgy is already researched
  4. Use the artillery stack with the relic (St. Almathea's Lancet) to attack the plague bomb
  5. Observe artillery get the plague (along with all the other player units)

Additional information:

It'd be nice to have some more detail in relics.dat, like how we have in the new sect.dat. I can assume that our relic is 100% prevention of plague in stack, but maybe not? I can assume that it's +50% defense bonus, but maybe it's just +50 defence points? And is it just Armor, or also Psy Defense? I can assume Accuracy is +8 points, but maybe it's +8%? That's all just nice to have though I guess.

Matt-Caspermeyer commented 1 year ago

It is actually working as intended, let me explain.

When you attack the Plague Bomb stack, you are set with a potential plague marker, not the plague. This means that all the units that have been exposed must make a saving throw. You will note that since you have a Plague Relic in the stack / on the planet Kish, that that relic bonus is not applied until the actual saving throw is made. That is after you end your turn. If you end your turn, you will note that no one gets the plague as they all make their saving throw due to the Relic's + 100 Plague Bonus. There are quite a few units that pass their saving throw due to it being half their health + bonuses (hospitals, relic, tech).

Hope this explains what is going on here...

If you are satisfied with this, could you please close this issue - thanks!

floralpond commented 1 year ago

Ok sounds good! Thanks, I've always wanted to learn more about how plague works but just haven't gotten around to it. No change needed here!