HDIAndrew / EFS

12 stars 0 forks source link

1.5.1c - captured relics don't work #144

Closed floralpond closed 1 year ago

floralpond commented 1 year ago

Description:

This issue was originally noted by Jakalor in discord, saying on 11/11 in t-general "You know, I realized we never fixed the old "Relics stop working if taken from another faction" bug"

When a relic is owned by another party such as a house, then captured by the human player, the relic no longer functions as intended.

Expected behavior: Relics should give bonuses to whoever controls them, as long as they have researched theurgy.

Actual behavior: If a relic is captured by combat, the relic no longer functions.

Game version:

1.5.1c

Steps to reproduce:

relic_capture_test.zip

  1. Load the attached save file "relic_capture_test.sav"
  2. Capture the other houses's Zebulon's Spade relic on Kish
  3. Move the relic to the Electronics
  4. Observe that the electronics production does not increase to 20. Current electronics is 30.
  5. End turn and observe that the next turn's electronics os only 40.

Additional information:

none

Matt-Caspermeyer commented 1 year ago

I have an update on this issue.

I have created a fix and it is currently undergoing our testing, review, approval, and merge process. Once this is complete we hope to include this fix in a future update (V1.51).