HDIAndrew / EFS

12 stars 0 forks source link

1.51c - the "+accuracy" and "*Attack Strength" modifiers in sect.dat are being applied twice #145

Closed floralpond closed 1 year ago

floralpond commented 1 year ago

Description:

In section I1 of Sect.dat, it has "+accuracy" and "*Attack Strength". These are being applied twice. So for example, Vau is +accuracy of 2, but if you look at their units, the accuracy value is added twice (+4 instead of +2), and the strength multiplier is multiplied twice (x1.56 instead of x1.25).

Same issue with Symbiot and Brother battle sects. Symbiot should be +1 accuracy and 1.10 strength, but they actually get +2 accuracy and 1.21 strength.

For example, shroud weaver is 4/100 ranged space in unit.dat, but in game it is 8/156 (should be 6/125). Blow ship is 8/100 in unit.dat, but in game is 10/121 (Should be 11/110)

image image

Expected behavior: Modifiers should reflect sect.dat settings.

Actual behavior:

"+accuracy" and "*Attack Strength" modifiers in sect.dat are being applied twice

Game version:

1.51c

Steps to reproduce:

Open the game Do HDIVIEW Check Vau and symbiot units

Additional information:

none

Matt-Caspermeyer commented 1 year ago

Do you know if it is only for display purposes or is it also during combat?

floralpond commented 1 year ago

Ran some tests to see if it's a display issue only, or does it also affect combat?

In my testing with no sect modifications:

in my testing with the symbiot sect modification:

Matt-Caspermeyer commented 1 year ago

I have an update on this issue.

I have created a fix and it is currently undergoing our testing, review, approval, and merge process. Once this is complete we hope to have this fix in a future update (V1.51).