HDIAndrew / EFS

12 stars 0 forks source link

Game crashes when merging a nonsentry cargo with a sentried cargo (that was sentried before the start of the turn). #148

Closed floralpond closed 1 year ago

floralpond commented 1 year ago

Description:

This issue was originally found by xenonaut on 1.5 and reported in discord. Game crashes when merging a nonsentry cargo with a sentried cargo (that was sentried before the start of the turn). The game does NOT seem to crash if the sentried cargo was sentried in the same turn as the merge attempt.

Expected behavior: Game should not crash when merging cargo.

Actual behavior: Game crashes when merging a nonsentry cargo with a sentried cargo (that was sentried before the start of the turn).

Game version:

originally found by xenonaut on 1.5 reproduced also on 886cfc9f by me

Steps to reproduce:

  1. merging_cargo_crash.zip
  2. Load the attached save file.
  3. On Kish, buy some metal from the agora
  4. Move the metal to the mine
  5. Merge the new metal with the previously sentried metal in the mine. The game crashes. (In 1.5, the game crashes after about 5 seconds. In 886cfc9f, the game seems to crash immediately).

Additional information:

none

Matt-Caspermeyer commented 1 year ago

I have an update on this issue.

I have created a fix that is currently undergoing our testing, approval, and merge process. Once that is complete this fix will be provided in the V1.51 update...