search

HDIAndrew / EFS

12 stars 0 forks source link

Map editor doesn't save Units with kind 89 #156

Open danieldfischer opened 1 year ago

danieldfischer commented 1 year ago

Description: Realizing I couldn't place Scientist unit (slot 89) with the map editor, I copied it to another slot to place on the map. After repeated attempts to test them in game I realized they weren't saving.

Expected behavior: Any unit placed on a planet with the map editor will be there the next time you open the galaxy in the editor or game.

Actual behavior: Units with kind 89 don't save.

Game version:

1.5.1 gold 3

Steps to reproduce:

  1. Set any unit to kind 89.
  2. Place unit with Map Editor.
  3. Save galaxy.
  4. Close Map Editor.
  5. Open galaxy in Map Editor (or game).
  6. The unit just placed does not exist.

Additional information:

To add a twist if you change the kind to 89 after having placed the units in a galaxy, the map editor will load and leave them in after saving.

Now this is a really niche case as unit slot 89 is not currently usable with the map editor and there is no particular reason to use kind 89. However if the unit is ever added to the map editor this will become an issue.

This does not appear to occur when using any other kind #, including Peasants (90, also unused), or a higher unused range (ex: 189).

Matt-Caspermeyer commented 1 year ago

Additionally, units of kind 90 (Peasants) are not saved either. Note that Peasants are special units that the game uses during rebellions .

I'm not sure what the history of the Scientist unit is, but I'm guessing that it was removed in V1.0 before originally released.

Since we are currently done with V1.51 development any changes here will have to await a future release.

As a work around, you can just use the scientist (same with the peasant, too) in a different unit slot / tLvl if you're into MODding.

I was going to use the Scientist to mark units as religious rebellion vs Peasants for normal rebellions, but the team decided against me generating Inquisitors from a unit that rebelled religiously. I may still use it to distinguish between the two different types of rebellion in the future or we can restore usage of the Scientist.

Feel free to comment your preference...