'Unit list out of order!' message after killing last noble of rival house

[cravus]

Description:

After killing last Noble of a rival house on the next turn I get a message 'Unit list out of order!' and can't skip it, clicking 'OK' or Esc does nothing.

Expected behavior: Game should continue, I guesss.

Actual behavior: After killing last Hazat Noble on Byzantium II after ending the turn on the next turn I get a message 'Unit list out of order!' that can not be skipped, clicking 'OK' or Esc does nothing, game has to be shut down from task manager.

Game version: 1.51 Nova 2.4

Steps to reproduce:

1. Kill all nobles from rival house
2. See the popout message at the start of the next turn

See attached save file, which is just after killing last Hazat noble on Byzantium II. Just end turn after you load it up, then next turn unskippable message should appear.

Additional information: save.zip

[Gohodoshii]

Same here

crash.zip

Edit from @floralpond: Additional information: this save is from 1.51, so this issue is not isolated to Nova and is critical for 1.51.

[Luxor70]

Issue seems to be in UNIT.CPP at lines 220 and 478

ifdef TEST_GROUPS

if (!AssertListSorted()) gMessageBox(0, GMB_OK, "Unit list out of order!");

endif

and

ifdef TEST_GROUPS

if (!UNIT_T::AssertListSorted()) gMessageBox(0, GMB_OK, "Unit list out of order! (DeleteUnit)");

endif

[floralpond]

@cravus @Gohodoshii thank you SO MUCH for including the save files!

[floralpond]

@Matt-Caspermeyer: Additional information found here: https://github.com/HDIAndrew/Patch/issues/817

[solr00t]

I was super excited to see that this game has been receiving updates, bought it as soon as I saw it on GOG. Thanks for keeping this gem alive! It looks like the current GOG release is 1.51 from February. Any guess when this patch is going to get rolled into the GOG release version? @floralpond