HDIAndrew / EFS

12 stars 0 forks source link

When Lander type units are defending on the ground and retreat from combat, they are destroyed and not capturable #165

Open floralpond opened 1 year ago

floralpond commented 1 year ago

Description:

When Lander type units are defending on the ground and retreat from combat, they are destroyed and not capturable.

Expected behavior: Retreating landers on the ground should move backward one hex like any other ground unit, then capturable. Or another possibility, if the surrendering unit can't move backward for whatever reason, then it just stays in the same hex, but is capturable.

Actual behavior: They are destroyed and not capturable.

Game version:

1.51 vanilla

Steps to reproduce:

  1. Load up lander_retreat_test.sav, attached to this issue report here:
  2. There are some low loyalty rebel landers near the Li Halan fort on Kish and a Li Halan blademaster and a bunch of trackers in the fort.
  3. Use the whole stack of trackers and blademaster to attack the assault landers
  4. some of the landers should surrender
  5. Move your trackers forward to see that the landers have disappeared.

Additional information:

Matt-Caspermeyer commented 1 year ago

I'm not 100% certain, but I thought that this was also in V1.4, but I may be mistaken.

Allowing them to move on land will fix this issue, but they are not allowed to and so that's why they die.

We'll probably have to discuss this issue during our next developer meeting to decide what to do...

floralpond commented 1 year ago

I think just making landers able to move won't really fix the issue, although it may mitigate it, because there is still the case of any other move type surrenders and can't move back for whatever reason (like for example, foot units backed up against water tiles with nowhere to run), then those units will be destroyed. So even if we allow landers to move on land, this issue of surrendering units being destroyed will still occur, but it's just most likely to happen with landers because they can't move on land.

Furthermore, allowing landers to move on land also changes how the game can be played a bit.

I don't know how easy it would be to implement, but I think surrendering units that don't have anywhere to go should just stay in the hex that they currently are in and not move would be my preference. Maybe this means they are basically auto-captured (like Jump or Space type units would be if they were in the defending stack), or that they aren't captured yet but still capturable.

Matt-Caspermeyer commented 1 year ago

I think just making landers able to move won't really fix the issue, although it may mitigate it, because there is still the case of any other move type surrenders and can't move back for whatever reason (like for example, foot units backed up against water tiles with nowhere to run), then those units will be destroyed. So even if we allow landers to move on land, this issue of surrendering units being destroyed will still occur, but it's just most likely to happen with landers because they can't move on land.

Furthermore, allowing landers to move on land also changes how the game can be played a bit.

I don't know how easy it would be to implement, but I think surrendering units that don't have anywhere to go should just stay in the hex that they currently are in and not move would be my preference. Maybe this means they are basically auto-captured (like Jump or Space type units would be if they were in the defending stack), or that they aren't captured yet but still capturable.

Actually, the more I think about this, the more I like it - if the unit can't move, for whatever reason, it just stays where it is. This is probably the best solution for the issue at hand...