HDIAndrew / EFS

12 stars 0 forks source link

Tech maintenance values are not subtracted from lab research points per turn #167

Closed floralpond closed 1 year ago

floralpond commented 1 year ago

Description:

Tech maintenance values are not subtracted from lab research points per turn. When you click on database, it lists a "maint" value for tech maintenance. Per the decades old manual, more techs cost more research points to maintain. I know the manual was never 100% accurate, but I do remember this in 1.4 as well and remember having to mass produce labs in order to get anything researched in a timely manner late game.

Expected behavior: You can always research techs at full steam ahead no matter how many techs you have researched.

Actual behavior: Tech maint is not subtracted from Lab points per turn

Game version:

1.51 vanilla

Steps to reproduce:

tech_maint_test.zip

see attached save file,

Press the end turn button then go into the lab each turn to see progress. You see that 85 points are deducted from Electron Microscopes each turn, instead of the expected 70 per turn.

<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns="http://www.w3.org/TR/REC-html40">

turn | Lab pts/turn | maint | Electron Microscopes pts left: | expected -- | -- | -- | -- | -- 1 | 85 | 15 | 325 | 325 2 | 85 | 15 | 240 | 255 3 | 85 | 15 | 155 | 185 4 | 85 | 15 | 70 | 115 5 | 85 | 19 | 0 | 49

Additional information:

Matt-Caspermeyer commented 1 year ago

I found the error - when I implemented the Sect Maintenance Cost bonuses, I divided that value by 100 to get the maintenance value. I neglected the fact that the total maintenance was divided by 100 again later, meaning that tech maintenance is now 1/10000 instead of 1/100.

So I've created a PR to fix this issue and it is now undergoing our testing, review, approval, and merging process. It will be provided in a future update...