search

HDIAndrew / EFS

12 stars 0 forks source link

Blatantly wrong information in Tech flavor text #170

Closed floralpond closed 9 months ago

floralpond commented 1 year ago

Description:

Typical_Name on discord pointed out a discrepancy in the tech flavor text for the tech "Wireblades", which says "Allows: Blademaster. Palaces can be built by Engineers". However, in strbuild.dat, Palaces don't need any technology to build.

Subsequent analysis shows that there are actually quite a bit of wrong pieces of information in the vanilla tech flavor text, such as:

  1. Xyll Warbeast: "Xyll Warbeasts can be built (grown) in Arboriums." But they are built in forts.
  2. Assault Legion: "Genetic Warrior Legions can be upgraded to Ranger Legions at Forts." but assault legion tech doesn’t give you Ranger legion.
  3. Dervishes: "Dervishes can be built in Churches.", but Dervishes are built in forts.
  4. assassin: "Spies can be upgraded to Assassins in Palaces.", but they are built in forts
  5. doppleganger: "Assassins can be upgraded to Doppleganger Assassins in Palaces." but they are built in forts
  6. Meditation: ""Churches can be built by Engineers. Allows Clergy to be built in Churches. ", but clergy can't be built
  7. Ceramsteel is cut off due to being too large. Last part is "Engineers…"
  8. Wireblades says "Palaces can be built by Engineers.", but palaces don't require any tech to build

And a similar issue, which Unfleshedone reported in discord:

  1. Archive entry for "Neurocellular Surgery" is set to 2.23, but the actual txt file is V2CHP022.TXT

Expected behavior: In game text should be correct.

Actual behavior: some in game flavor text for Techs do not give correct information.

Game version:

1.51 Vanilla

Steps to reproduce:

Probably easiest to just look at tech.dat. But you can see this stuff in game in the tech selection research screen.

Additional information:

none

HDIAndrew commented 1 year ago

Good catches!

Matt-Caspermeyer commented 1 year ago

I think a lot of these came from Hyperion - I basically used the Hyperion Tech Tree costs for the vanilla game and so I thought most of this information was pertinent, but obviously it wasn't.

Okay - I've created a PR that should fix this and it is currently undergoing our testing, review, approval, and merge process.

I think with Ceramsteel, since it allows so many things that its field sized needed to be increased. We'll see how the testing goes...