HDIAndrew / EFS

12 stars 0 forks source link

Crash upon opening combat message #18

Closed Jakalor closed 2 years ago

Jakalor commented 2 years ago

Description: Hitting the Enter Key too fast at the start of the turn when it prompts you about messages causes a crash if you then go back to read messages again.

Expected behavior: Hitting the Enter Key simply lets you quit through the messages rather than have to read them all at the start of the turn Actual behavior: If you hit the Enter key fast enough after getting to messages causes a crash when it tries to show attacks on your forces during the previous turn cycle.

Game version:

[efs_a2]

Steps to reproduce:

  1. Start a turn (from loading a save or playing the game) where you were attacked during the previous turn cycle
  2. Hit enter without pausing
  3. Try to read messages again through the messages menu
  4. Crash on trying to show the battle

Ad

Log_Save_4968.zip ditional information:

Lobachevskiy commented 2 years ago

This happened due to combat messages being corrupted sometime during or after being added to the queue. If you open the messages slowly or via mouse it still crashes. Just by launching another combat I could not reproduce it, it worked, so we need to catch it again and have a save before combat is initiated as well.

Lobachevskiy commented 2 years ago

Is this still an issue?

danieldfischer commented 2 years ago

I believe this is still an issue. SAV.zip

Description: Game crashes to desktop after loading specific saves with combat messages.

Expected behavior: Load a save file. Get House starting screen, click okay. View combat reports for the turn.

Actual behavior: Load a save file. Get House starting screen, click okay. Make research or production selections if available. Game crashes to desktop with no error message before seeing combat reports.

Game version: efs_b3 fresh install, no modifications.

Steps to reproduce:

Load save file "t.sav", "T2.sav", or "t3.sav" Crash occurs immediately after clicking okay, initial screen would've been a combat report. Repeatedly doing this would occasionally load successful after 6-10 attempts.

Load save files "Log_Save_4958.sav" or "Log_Save_4959.sav" Making research & production selections. Crash occured more often than not before the combat report.

Additional information:

To further complicate the matter I found that if you successfully load a save file, you will then be able to load saves that were crashing at the combat message more often than not.

To recreate: Load "Log_Save_4957.sav" From that game load a corrupt save, ex: "t.sav" Repeat with other corrupt save files, ex: "t2.sav"

I repeated this about a dozen times, with maybe 2 crashes.

HDIAndrew commented 2 years ago

Great catch, thanks