HDIAndrew / EFS

12 stars 0 forks source link

Deselecting default traits may not always disable them #83

Open YeOldeEBM opened 2 years ago

YeOldeEBM commented 2 years ago

Description:

In my current game as Decados I had a rebellion thwarted by Internal Security Apparatus (a trait Decados starts with), but at the start of the game I had deselected all the positive traits. See images below.

It's not a critical bug and isn't something most players will encounter, so shouldn't delay the 1.5 release. Will need some investigation to see if any other default traits don't disable when deselected. I can confirm the two Ancient Documentarium traits Decados starts with are correctly disabled if deselected but I'm not sure of the others.

Expected behavior:

Deselecting default traits disables their effects.

Actual behavior:

Internal Security Apparatus continued functioning despite being deselected.

Game version:

1.5g2

Steps to reproduce:

  1. Start the game as Decados on Beginner
  2. Deselect the Internal Security Apparatus trait
  3. Push Tax and Tithe sliders to maximum
  4. End turns until rebellions begin
  5. Check for Internal Security Apparatus message (may take a turn or two of rebellions for it to fire)

Additional information:

thwarted1

The in-game traits screen showing I had deselected Internal Security Apparatus and the other positive traits. thwarted2

Matt-Caspermeyer commented 1 year ago

Interesting problem...

I'm thinking that it's possible that the message about Internal Security Apparatus could be errant, but I'm not certain.

I'll see if I can figure out what's going on here for V1.51, but I'm not certain if it will be for that or a later release...

YeOldeEBM commented 1 year ago

I just got the Internal Security Apparatus message as House Hawkwood while never having the trait, so you might be right in the message being errant.

Hawkwood Internal Security