PBEM Games, The Save Game Dialog, and the Cancel Button

[Matt-Caspermeyer]

Description:

There has been talk in Discord about an issue involving the Cancel Button when saving games in a PBEM game.

Here is the real problem and why it cannot be allowed:

1. A player is asked to end their turn - this is the time for the player to determine if they really want to end their turn or not.
2. If the player says "No" to this dialog then they can continue their turn - no issue.
3. If the player says "Yes", then the game runs end of turn code that cannot be undone.
4. Since the player said "Yes" to the end turn dialog, they have chosen to end their turn and since the execution of the end turn code is final, the player must save their game when the save game dialog appears.

So we probably should disable the Cancel button for PBEM games at this point, if this is the case, since the player must save their game at this point. There are no do-overs here and the player had the chance to continue their turn, but decided not to.

We can also just have a popup menu to tell the player that canceling is not allowed, but disabling the button is probably better.

Thoughts?

P.S. Undoing the end turn code is probably not an option at this point and this is most likely a V1.51 or V1.6 thing...

[HDIAndrew]

Thanks for the break down, Matt. For 1.51 I am happy to either leave it alone or add the pop up you mention. It is an annoyance, and not critical. We don't need to do anything before 1.51 other than mention it in the FAQ. I mean, if this is the main bug people complain about, we are in soooo much better shape than we were with 1.4 :)