HDInnovations / UNIT3D-Community-Edition

Private Torrent Tracker Built With Laravel, Livewire and AlpineJS.
GNU Affero General Public License v3.0
1.94k stars 370 forks source link

[Bug] Manual user "can_download" get's overwritten by AutoGroup system #1820

Open Alkl58 opened 3 years ago

Alkl58 commented 3 years ago

Describe the bug When setting the download permission of a user, it's gets overwritten in certain intervals by the AutoGroup system.

To Reproduce Steps to reproduce the behavior:

  1. Set "can_download" from a user
  2. Wait for AutoGroup / or some other system
  3. See the user getting the can_download permission back

Expected behavior AutoGroup System should respect the pemission set to a specific user.

Screenshots n/a

UNIT3D (please complete the following information):

Desktop (please complete the following information):

Additional context I am not entirely sure if it is the AutoGroup System, but this is the most likely culprit.

Possible Fix? n/a

Upvote & Fund

Fund with Polar

Alkl58 commented 3 years ago

Issue seems to be: https://github.com/HDInnovations/UNIT3D-Community-Edition/blob/f801b148dbc316a01ee7444f12e43c100f002205/app/Console/Commands/AutoRevokePermissions.php#L56

In my opinion this line is not needed, as 'can_download' => '1' should be set by autogroup.

HDVinnie commented 2 years ago

This will be resolved in @clandestine8 RBAC branch

Audionut commented 1 month ago

This seems fixed now.

Roardom commented 1 month ago

This is not fixed: https://github.com/HDInnovations/UNIT3D-Community-Edition/blob/e736d2973fd6d2af5f219832475735fd81b1b37c/app/Console/Commands/AutoGroup.php#L82