search

HDLUtils / hdlregression

MIT License
15 stars 5 forks source link

Change install description to use the standard preferred python way. #23

Closed sverrham closed 5 months ago

sverrham commented 5 months ago

pip install -e . will install the package in editable mode so it can be modified but it is handled by the pip python package management system.

setup.py as a command line tool are deprecated. https://packaging.python.org/en/latest/discussions/setup-py-deprecated/

sverrham commented 5 months ago

Feel free to not accept this, this is just issues I have seen trying to use it right now.

The pip install -e . is better I believe.

I assume the bug with module imported is seen because of this? or nobody uses it with installed packages, only direct reference to module path?

What is this crazyness, trying to run the tests with pytest deletes the module folder, this is craycray, or I do not understand how this repo is made to be developed on...

sverrham commented 5 months ago

right, so you need to run the tests from test\unit, still got 31 failing tests...

sverrham commented 5 months ago

I got it down some more (5 failing tests), and I guess the issue now is the change of the output folder from hdlregression to hdlregression_output and I guess that should probably not be merged as is.

Feels wrong with having it create files in a folder with the same name and so it tries to import from that folder. can be something wrong with my setup but feels like it should not have that problem...

sverrham commented 5 months ago

Still more hardcoded paths and this should all be updated to use the settings output path I think. Also there are some failing tests and I have not updated the hardcoded paths in the tests.

I can fix all those but would like some feedback if this makes sense, if not I will not spend the time doing these changes.

Probably would be nice to be able to change this runtime, and maybe it already is possible 🤔