search

HDR / Player_Glow_Sponge

This plugin is no longer supported, The repository has been archived, a full rewrite may happen in the future
MIT License
0 stars 3 forks source link

Simplify plugin and replace old menu #6

Closed SubtypeZero closed 6 years ago

SubtypeZero commented 7 years ago

I noticed that @vsddev implemented a fix for #5 and felt like I could further improve the plugin, so I spent some time cleaning things up. Most of the changes I have made were to simplify how the commands work, making it unnecessary to have one command class per color. With all of those changes and the removal of the menu, I believe this brings us to version 1.2 and makes the plugin much easier to use. The old menu was nice, but using a single command to change colors and toggle the effect makes it easier to find the color you want and avoids filling up your chat log. I have also spent some time testing these changes to make sure everything works. Here's a built jar of the new version: PlayerGlow-Sponge-1.2.zip

SubtypeZero commented 7 years ago

I realize you might be thinking that this changes too many things, but I hope you're willing to give it a shot because this seems like a major improvement to me

SubtypeZero commented 7 years ago

Oops, I accidentally closed the PR

HDR commented 7 years ago

Hi, thanks for the pull request, i'll take a look at this if i have some time later :)

HDR commented 6 years ago

Hi, sorry for taking a while to get back to you, haven't been active when it comes to minecraft, as it stands i don't really want to remove the chat menu, but i'm open to implementing your other changes.

SubtypeZero commented 6 years ago

There may be a couple issues that still need to be addressed (not sure if these changes are the cause), but that shouldn't be too difficult to fix. I think you'd like the menu replacement if you gave it a shot. Using /glow is much easier and doesn't spam up your chat history. The way I see it, it's not necessary to have a chat GUI when the plugin is super easy to use and you can tab complete the color argument for /glow.