search

HEASARC / sciserver_cookbooks

Jupyter notebook tutorials/cookbooks demonstrating analysis on the SciServer platform
MIT License
5 stars 7 forks source link

Added Getting-Started, nustar_lightcurve_example and nicer-example notebooks #3

Closed zoghbi-a closed 1 year ago

zoghbi-a commented 2 years ago
zoghbi-a commented 2 years ago

@trjaffe, @mfacorcoran, The last commit also includes the nicer-example notebook, with some code at the top to check that heasoftpy has the correct version (>1.1) to ensure nicerl2 run correctly, and if it doesn't, grab the latest one from github.

trjaffe commented 2 years ago

Looks good to me. I think we should also ask Manu to update the image when we think we have a version of heasoftpy ready to release. But this is probably going to come up again, so an example of how to work around like this is a good idea.

zoghbi-a commented 2 years ago

0b4d7295a22131f33a0eb56dd0167439a34664c3 updates the kernel in the rest of the notebooks and adds the extra code that ensure heasoftpy>1.1 when needed. We can remove it once we update heasoftpy

zoghbi-a commented 2 years ago

The conflict reported by github is because I deleted rxte_example_lightcurves_noWurlitzer.ipynb, which, to me, looked the same as rxte_example_lightcurves.ipynb. @trjaffe, are there any differences between the two that I missed?

trjaffe commented 2 years ago

@trjaffe, are there any differences between the two that I missed?

No, indeed I had planned to delete it.

zoghbi-a commented 2 years ago

I added an intro document to serve as an index page. Once merged, the sciserver image will download this repo and launch that page when the compute image is launched.

trjaffe commented 2 years ago

Since the HEASARCv6.30.1 image has been updated with the heasoftpy version to fix the nicer notebook, let's remove the code that does a fresh install.

And sorry @mfacorcoran , I had forgotten about this one. I'd suggest Abdu make that one additional fix, and I'll test the rest, Mike too, and then we'll merge this one and close the other PR.

zoghbi-a commented 2 years ago

@trjaffe, @mfacorcoran: The notebooks should be ready for a final round of testing.

trjaffe commented 2 years ago

Tested them all, and it all looks good. Cannot find an "approve PR" button.