thelabeljoyves commented 4 years ago

the sound need the 3:2 div, so that in doesn't jump around in the carousel:


<div style="width:100%;padding-bottom:66.6%;position:relative;">                  
   <audio id="background-audio" controls style="outline: none;">
      <source src="https://cdn.hotelkrone.be/artworks/Dont_worry.mp3" type="audio/mpeg">
   </audio>
</div>

VenzinJonas commented 4 years ago

In a student room or overlay or both ?

Can you give me some examples ?

thelabeljoyves commented 4 years ago

it’s only for the media “void” in the carousel by benjamin gaschen in his Seite

On 26 Jun 2020, at 13:40, Venzin Jonas notifications@github.com wrote:

In a student room or overlay or both ?

Can you give me some examples ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HEG-Arc/HotelKroneHKB/issues/101#issuecomment-650134096, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGQNVJJI5GNNV5IWSALDPDRYSCJLANCNFSM4OJGR7FQ.

cgaspoz commented 4 years ago

C'est quand même pas beau ce petit player :-(

@thelabeljoyves tu penses quoi de ça:

thelabeljoyves commented 4 years ago

oui mais non, on fait comme c’était pas de fantaisie: on a fait un check complet ce matin, je veux pas de nouvelles questions :-)

On 26 Jun 2020, at 17:44, Cédric Gaspoz notifications@github.com wrote:

C'est quand même pas beau ce petit player :-(

@thelabeljoyves https://github.com/thelabeljoyves tu penses quoi de ça: https://user-images.githubusercontent.com/438609/85875471-8923dc80-b7d4-11ea-8db3-ee7c71a46dd9.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HEG-Arc/HotelKroneHKB/issues/101#issuecomment-650249745, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGQNVM5ZOM5RQJRR62LM7TRYS65VANCNFSM4OJGR7FQ.

thelabeljoyves commented 4 years ago

Hello

I think we’re good with the website!!! Bravo!

We’re still testing the stream, but that’s all.

love, Yves

On 26 Jun 2020, at 18:01, Cédric Gaspoz notifications@github.com wrote:

Closed #101 https://github.com/HEG-Arc/HotelKroneHKB/issues/101.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HEG-Arc/HotelKroneHKB/issues/101#event-3487201763, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGQNVOU6P5YZCZTC7RVGTDRYTA5FANCNFSM4OJGR7FQ.

thelabeljoyves commented 4 years ago

now the player is outside of the box, which pushes the whole frame down I liked the other player with the rounded corners…

On 26 Jun 2020, at 17:44, Cédric Gaspoz notifications@github.com wrote:

C'est quand même pas beau ce petit player :-(

@thelabeljoyves https://github.com/thelabeljoyves tu penses quoi de ça: https://user-images.githubusercontent.com/438609/85875471-8923dc80-b7d4-11ea-8db3-ee7c71a46dd9.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HEG-Arc/HotelKroneHKB/issues/101#issuecomment-650249745, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGQNVM5ZOM5RQJRR62LM7TRYS65VANCNFSM4OJGR7FQ.

cgaspoz commented 4 years ago

Si tu dois changer le player, le style est dans le css:

/* AUDIO PLAYER */

.student-player {
  width:100%;
  padding-bottom:32.6%;
  padding-top:30%;
  position:relative;
}

div.student-player #background-audio {
  width: 80%
}

thelabeljoyves commented 4 years ago

ok, en fait c’est dépendant du browser. bon, on s’en fiche. Par contre il faut corriger le fait qu’il soit au-dehors du cadre et pousse le reste de la page vers le bas.

On 26 Jun 2020, at 18:31, Cédric Gaspoz notifications@github.com wrote:

Si tu dois changer le player, le style est dans le css:

/ AUDIO PLAYER /

.student-player { width:100%; padding-bottom:32.6%; padding-top:30%; position:relative; }

div.student-player #background-audio { width: 80% } — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HEG-Arc/HotelKroneHKB/issues/101#issuecomment-650273261, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGQNVKWNJJGTTXIF4RA2N3RYTEOXANCNFSM4OJGR7FQ.

thelabeljoyves commented 4 years ago

Maybe it was all a temporary bug during the working? It was alright some days ago.

On 26 Jun 2020, at 18:31, Cédric Gaspoz notifications@github.com wrote:

Si tu dois changer le player, le style est dans le css:

/ AUDIO PLAYER /

.student-player { width:100%; padding-bottom:32.6%; padding-top:30%; position:relative; }

div.student-player #background-audio { width: 80% } — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HEG-Arc/HotelKroneHKB/issues/101#issuecomment-650273261, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGQNVKWNJJGTTXIF4RA2N3RYTEOXANCNFSM4OJGR7FQ.

cgaspoz commented 4 years ago

Chez moi c'est bon sur tous les browsers. La forme du player c'est lié au browser, c'est chrome qui a un player avec les bords ronds. Sinon, sur mobile il garde pas le ratio. Tu dois peut-être jouer avec la CSS.

thelabeljoyves commented 4 years ago

ni sur le desktop. mais y eu un moment où c’était réglé. Y a un truc qu’à cassé qq part

On 26 Jun 2020, at 18:45, Cédric Gaspoz notifications@github.com wrote:

Chez moi c'est bon sur tous les browsers. La forme du player c'est lié au browser, c'est chrome qui a un player avec les bords ronds. Sinon, sur mobile il garde pas le ratio. Tu dois peut-être jouer avec la CSS.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HEG-Arc/HotelKroneHKB/issues/101#issuecomment-650280410, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGQNVPY7TYYNLQBF7WZYZLRYTGCDANCNFSM4OJGR7FQ.

cgaspoz commented 4 years ago

Vider le cache du browser? En tout cas, moi j'ai que du tout bon...