search

HENNGE / aiodynamo

Asynchronous, fast, pythonic DynamoDB Client
https://aiodynamo.readthedocs.io/
Other
73 stars 21 forks source link

Support consistent read #101

Closed jarikujansuu closed 2 years ago

jarikujansuu commented 2 years ago

Purpose

Support consistent read in get_item, query, scan, count and batch get operations.

Note: Tests do not actually check anything except that DynamoDb calls do not explode if using consistent_read option. Local DynamoDb is always strongly consistent. And might want to reduce copied code in them.

ojii commented 2 years ago

Tests do not actually check anything except that DynamoDb calls do not explode if using consistent_read option.

that's fine, but could you please change the tests to use @pytest.mark.parametrize since the new tests seem to just be a copy/paste of existing ones with a single parameter changed.

jarikujansuu commented 2 years ago

Rerequested review as changed how ConsistentRead is added to request payloads

dimaqq commented 2 years ago

my 2c: types in the test parameters are minor; perhaps we can merge and fix that later?

ojii commented 2 years ago

my 2c: types in the test parameters are minor; perhaps we can merge and fix that later?

done.

@jarikujansuu thank you for the PR