HENNGE / aiodynamo

Asynchronous, fast, pythonic DynamoDB Client
https://aiodynamo.readthedocs.io/
Other
69 stars 20 forks source link

circleci ➡️ github actions #122

Closed ojii closed 2 years ago

ojii commented 2 years ago

would be nice to reduce some of the repetition but i'm just happy it works at all.

ojii commented 2 years ago

by far the slowest part of this whole ci pipeline is poetry install without a lock file. I wonder if it's possible to only run this once (or rather, run poetry lock) and then re-use it in subsequent steps.

dimaqq commented 2 years ago

by far the slowest part of this whole ci pipeline is poetry install without a lock file. I wonder if it's possible to only run this once (or rather, run poetry lock) and then re-use it in subsequent steps.

maybe that's a good reason to check in poetry.lock, finally?

ojii commented 2 years ago

maybe that's a good reason to check in poetry.lock, finally?

I still think that's a bad practice for libraries.

ojii commented 2 years ago

Merge it, improve later!

i wanna mess in this branch a bit until it's somewhat decent and then squash the commits