search

HENNGE / aiodynamo

Asynchronous, fast, pythonic DynamoDB Client
https://aiodynamo.readthedocs.io/
Other
72 stars 21 forks source link

Fix poetry lock running forever #156

Closed FurqanHabibi closed 1 year ago

FurqanHabibi commented 1 year ago

Dependency resolution took a long time because poetry chose the wrong version of urllib3. Specifying the urllib3 version solve the resolution.

stupoid commented 1 year ago

@hanscg Just checking, is it ok to merge this in?

hanscg commented 1 year ago

@stupoid It looks good to me, but I don't exactly manage this repo 🙇

@ojii Any comments? Otherwise I'll merge this

ojii commented 1 year ago

@ojii Any comments? Otherwise I'll merge this

I'm a little unhappy about setting an upper bound on urllib3 instead of a lower one but if this is needed, i don't have an objection to merging it.

hanscg commented 1 year ago

Let's merge and see if we can do anything about urllib later 🙏